commit 2884226fe27cd3e4d5f4a070405c047183fed881 Author: Jan Kissig Date: Fri May 3 14:11:58 2024 +0200 Bug 36772: OPAC Self checkout accepts wrong or partial barcodes When using the opac trusted checkout feature it is possible to enter non existant or partial barcodes to check out items. Testplan: a) set System preference OpacTrustedCheckout to Allow b) go to http://localhost:8080/ and login with koha / koha c) click Self Checkout in navigation bar d) enter barcode 1234 e) result: Item '39999000011234' was checked out apply patch and reload the page a) now enter barcode 1234 b) result: Item '1234' not found c) enter 39999000011234 d) result: Item '39999000011234' was checked out Signed-off-by: Matt Blenkinsop Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit a0b1ee7df30a191a65fc44020bbe18dd69366ce2 Author: Emmi Takkinen Date: Fri May 10 08:31:42 2024 +0300 Bug 36825: Hide "Protected" field via BorrowerUnwantedField syspref Setting field "Protected" as hidden in patron entry/modification form via BorrowerUnwantedField syspref doesn't work. Form is missing condition "UNLESS noprotected". To test: 1. From BorrowerUnwantedField, check field "Protected" as hidden. 2. Either attempt to create a new patron or modify existing one. => Note that "Protected" is still displayed in the form. 3. Apply this patch. 4. Navigate back to create/modify patron form. => Note that "Protected" is no longer displayed. 5. Uncheck field "Protected" from BorrowerUnwantedField. => Field should now be displayed in create/modify form. Sponsored-by: Koha-Suomi Oy Signed-off-by: Andrew Fuerste Henry Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit 537d5aac5ac46718e3a1a5f8dac2baf26a8abdea Author: Tomás Cohen Arazi Date: Mon May 13 12:06:02 2024 -0300 Bug 36837: (follow-up) UNIMARC case I checked the UNIMARC authResults counterpart file. And it only contained a single case of generated elements like the previous patch. To test: 1. On latest main $ ktd --shell k$ cd misc/translator/po k$ git fetch k$ git reset --hard origin/main k$ cd /kohadevbox/koha k$ gulp po:update --lang es-ES k$ cd misc/translator/po k$ git add -u ; git commit -mWIP --no-verify 2. Apply this patches 3. Run: k$ cd /kohadevbox/koha k$ gulp po:update --lang es-ES k$ cd misc/translator/po k$ git diff => SUCCESS: Notice CSS class names are not translated anymore Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit 48e39c1e5cea2db2c4e0951a6efcae7e611490fb Author: Tomás Cohen Arazi Date: Mon May 13 10:58:48 2024 -0300 Bug 36837: Simplify XSLT and aid translatability This patch makes the XSLT contain HTML tags instead of building them from scratch with static attribute values. This made it awkward for translators as CSS classes ended up being extracted for translation purposes. Plus, there's no need to spend CPU cycles on static content generation. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit d4c70f7d07dcc0fe1319b6e0380abcd1b7400b95 Author: Janusz Kaczmarek Date: Tue Apr 18 21:42:24 2023 +0200 Bug 33099: Add missing MARC21 Match authority mappings so "Search all headings" search works The main entry form of corporate names (110), uniform titles (130), topical terms (150), geographical names (151), and genre/form (155) are not indexed with 'Match' search field in Elasticsearch standard mapping. As a result, the respective records are not present on the result list when performing an 'All headings' search for the authority records with the main heading form (MARC 21). Test plan ========= 0. Have a test installation with Elasticsearch. 1. In Authorities, make an 'All headings' search for a main entry form from the corporate names, uniform titles, topical terms, geographical names, or genre/form --> e.g., in ktd: UK Archiving. You will get no results. 2. Apply the patch, reindex with: sudo koha-elasticsearch --rebuild -r -a kohadev 3. Repeat the test. You should see 'UK Archiving' on the result list. Signed-off-by: Roman Dolny Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 7291a312332e4fac7ac61288f33a001d4a7b306c Author: Kyle M Hall Date: Wed Mar 20 15:32:50 2024 -0400 Bug 36378: Cannot stay logged in if AutoLocation is enabled but branch ip is not set correctly We can get into a scenario what a user cannot stay logged in for more than a single page load. If AutoLocation is enabled with branch IP addresses being set to a space, you will be logged out with every page load. Test Plan: 1) Set your branch ip to a space 2) Enable AutoLocation 3) Restart all the things! 4) Log out 5) Log in 6) Browse to another page 7) You are logged out 8) Apply patch 9) Repeat 1-6 10) You are not logged out! Signed-off-by: Andrew Fuerste Henry Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 02eae879ebf8bab98010b92e9913a79264185533 Author: Lucas Gass Date: Mon Apr 29 15:18:26 2024 +0000 Bug 36708: Fix column index for processing No automatic renewal after To test: 1- Find or create a circulation rule with a 'Holds allowed (total)' limit of 3 (or another number) and no value in 'No automatic renewal after (hard limit)' 2- Select to edit the rule, and note that 'No automatic renewal after (hard limit)' box in the editing line is now populated with a date 3- Note also that 'Holds allowed (total)' is empty in your editing line 4- If you save your edits without clearing the new 'No automatic renewal after (hard limit)' date, it will save as part of the rule. Also, 'Holds allowed (total)' will save as Unlimited unless you re-add your numerical value. 5- APPLY PATCH 6- Try again, the values should save corrected and not erroneously fill the No automatic renewal after (hard limit) column. Signed-off-by: Andrew Fuerste Henry Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 3af27824b73af78b432b0c177892afa90c4b7f23 Author: Jonathan Druart Date: Tue May 14 14:47:33 2024 +0200 Bug 35862: Fix patron_search_form selection We were no longer getting a match here and so ended up with 2 forms on the budget page (where we have two modals for patron: owner and users). Caught be selenium tests patrons_search.t : Error while executing command: element not interactable: Element could not be scrolled into view It fixes the following UI issues: When you open a modal, start a search, close the modal open the other modal search: the results from the other modal were shown Signed-off-by: Katrin Fischer commit 6d8f72efa0570141fd5bbe4b0a86c70dde74f945 Author: Jonathan Druart Date: Tue May 14 14:46:29 2024 +0200 Bug 35862: Remove dup aside node The aside element is now a parent of the form block, in patron-search.inc (BLOCK patron_search_filters). On members/members-home.pl there were 2 nested aside Signed-off-by: Katrin Fischer commit 69c64bcb7284fc7de487d37543a2815c07270f53 Author: Jonathan Druart Date: Tue May 14 11:51:11 2024 +0200 Bug 35362: Adjust other "Close window" clicks Previous patch "Bug 35362: (follow-up) Fix guaruntor preview modal close in test" didn't adjust the other occurrences. Signed-off-by: Katrin Fischer commit 33e9127082cd16f5e71ea4eb0adf3f8d1a6441eb Author: Jonathan Druart Date: Tue May 14 10:41:20 2024 +0200 Bug 36018: Prevent random failure from api/v1/acquisitions_orders.t Signed-off-by: Katrin Fischer commit 150914e2345b685fb2563df91b564713ef3b1941 Author: Matt Blenkinsop Date: Mon May 13 14:21:05 2024 +0000 Bug 34788: (follow-up) Fix unit tests prove t/db_dependent/Koha/BackgroundJob/ImportKBARTFile.t Signed-off-by: Katrin Fischer commit b7e5dab1e71c46a52a94a0b5c244a716653b61be Author: Nick Clemens Date: Mon May 13 14:03:47 2024 +0000 Bug 30047: (follow-up) Fix failing tests This patch updates the test files to correctly create authorities and/or correctly mock the needed data for authorities. the tests in t/db_dependent/Authority/Merge.t cover the case of 'Default' authorities which don't have valid headings - so I had to add handling for blanking the heading field when Default type is used. Signed-off-by: Katrin Fischer commit aae125044d78f9f1a71bdc229b029db585422890 Author: Owen Leonard Date: Mon May 13 13:46:03 2024 +0000 Bug 36838: Add CSRF token to tags review AJAX requests The JavaScript for approving or rejecting tags in the staff interface's tag review interface lacked a CSRF token for the POSTed requests. This patch adds the token for "approve" and "reject" operations. To test, apply the patch and clear your browser cache if necessary. - If necessary, enable tags in system preferences. - Log in to the OPAC and submit multiple tags on various records. - In the staff interface, go to Tools -> Tags. - Test the process of approving and rejecting tags by clicking the buttons in each row of the table of tags. - The browser console should show no errors, and the lists of approved and rejected tags should correctly show the tags you moderated. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 43eb61f0d80cf69a90e08ed877491a432b7c7f04 Author: Jonathan Druart Date: Mon May 13 15:59:57 2024 +0200 Bug 29948: Adjust sysprefs.sql Signed-off-by: Katrin Fischer commit fffb3665eadec04792b055e9ba04152b3b36d6dd Author: danyonsewell Date: Fri May 10 02:40:45 2024 +0000 Bug 36723: Add musical presentation to Elasticsearch index mappings Testing plan: 1. Start up KTD with Elasticsearch: ktd --es8 up 2. Apply the patch and restart everything (restart_all). 3. Reset the mappings: Administration > Catalog > Search engine configuration (Elasticsearch) > Reset mappings (at the bottom of the page) 4. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev 5. Alternative to steps 3 and 4: reset_all 6. Update the visibility for 254$a in the default framework so that it is visible in the Editor (OPAC, Staff interface should already be selected). 7. Add a new record using the default framework and put a term in 254$a, such as 'Full score'. Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind Signed-off-by: Katrin Fischer commit 4b8dad9a8e5c70e4ec5e1d7f29790b6fd4e3796f Author: Owen Leonard Date: Mon Apr 1 13:04:06 2024 +0000 Bug 36472: Add search box at the top of the authorities editor page This patch adds the authority search header include to the authorities editor page. To test, apply the patch and go to Authorities -> New authority. There should now be a set of authority search forms at the top of the page. Signed-off-by: Michelle Spinney Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit be98d633be1fb34f52ccc8b57b18280856cf1d1a Author: Lucas Gass Date: Wed Mar 6 18:41:04 2024 +0000 Bug 34823: Do not show Item group dropdown if there are no item groups To test: 1. Enable EnableItemGroups and EnableItemGroupHolds 2. Go to the OPAC and log in as a patron 3. Go to any record that doesn't have grouped items and try to place a hold 4. Click on "Show more options" 5. See "Request specific item group:" and dropdown 6. APPLY PATCH 7. Try again, this time if the record has no item groups you should not see the dropdown at all. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit 2d34006653b96c0beaa4bc250f9eec8207ba5116 Author: Emily Lamancusa Date: Fri May 10 16:35:01 2024 -0400 Bug 36440: (QA follow-up) Update op parameter Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit 6e6167f3e14337402d7ac219a7c521d49ec79015 Author: Stefan Berndtsson Date: Fri Nov 3 10:14:39 2023 +0100 Bug 36440: Add edit buttons for patron flags in attention box Add edit buttons for patron flags in attention box and show flag status in detail view To test: 1) Go to patron details for a patron with address in doubt and card lost flags set and verify these are highlighted under "Library use" and the patron messages has edit buttons that links to the modfiy patron page. Sponsored-by: Gothenburg University Signed-off-by: Lucas Gass Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit 36eab911dda07d922e0b139f3d1f8aa982f15e00 Author: Laura Escamilla Date: Thu Apr 4 12:31:59 2024 +0000 Bug 26654: Added item number column to item search Test plan: 1. Apply patch 2. Do an item search and notice the column containing the item number Signed-off-by: Michelle Spinney Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 0fcd0a92de8235487b3e2d2ce2ed0fb63b59d3f6 Author: Katrin Fischer Date: Mon May 13 11:29:35 2024 +0000 Bug 29948: (follow-up) Add CSS class to list items This will allow to hide some of the entries by their source from $2. Signed-off-by: Katrin Fischer commit 5f7dd9c62db1d78fe705f524517e6c969ab5ad80 Author: Katrin Fischer Date: Mon May 13 10:11:33 2024 +0000 Bug 29948: DBRev 23.12.00.057 Signed-off-by: Katrin Fischer commit 88acb4ea49ae271127434729fac2ee5f5dd658bf Author: Jonathan Druart Date: Mon May 6 12:22:42 2024 +0200 Bug 29948: Remove margin bottom for paragraph Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit bc77ca128a630487c807cded01c9bfdfdf28b90e Author: Jonathan Druart Date: Mon May 6 12:18:55 2024 +0200 Bug 29948: Hide entry if empty Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit bdc06dd36f6651f0cc6d5f8a4140c50c75564c9f Author: David Nind Date: Mon May 6 06:48:28 2024 +0000 Bug 29948: (follow-up) Update system preference description and heading This follow-up: 1. Updates the OPACAuthorIdentifiersAndInformation system preference description. 2. Changes the OPAC heading used on the bibliographic record and authority record detail pages from "Author identifiers/information" to "Author information". Identfiers are a subset of author information and having just "Author information" is sufficient. In addition, the authority record doesn't have to include identifiers. Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 3c503a159500a7e66d9d63c9905a04480b753f71 Author: Jonathan Druart Date: Fri Mar 22 12:46:21 2024 +0100 Bug 29948: Fix display of selected values The values were correctly inserted but the display was not sorting correctly Signed-off-by: Signed-off-by: Hugo Agud Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 6f1b00e24d83f79ab74d8f6bd1b33ead3ef9a671 Author: Jonathan Druart Date: Thu Mar 14 10:40:29 2024 +0100 Bug 29948: Allow to sort info With this patch the different info can be ordered when editing the syspref Sponsored-by: Orex Digital Signed-off-by: Signed-off-by: Hugo Agud Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 40ca270825734e9716871401cabd86414ff4c470 Author: Jonathan Druart Date: Thu Mar 14 09:58:05 2024 +0100 Bug 29948: OPACAuthorIdentifiersAndInformation This patch merge the previous patch attempt with the existing OPACAuthorIdentifiers syspref. It creates a new syspref OPACAuthorIdentifiersAndInformation and remove OPACAuthorIdentifiers. "identifiers" become an entry of the new syspref. Test plan: Select some entries in OPACAuthorIdentifiersAndInformation Edit an authority record and enter data in the corresponding subfield (the list is on the syspref entry) Go to the biblio detail page or the authority detail page at the OPAC and notice that the info you selected are correctly displayed. Sponsored-by: Orex Digital Signed-off-by: Signed-off-by: Hugo Agud Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 070f720aaeda27ff0d863fe20a3cd60743558167 Author: Jonathan Druart Date: Wed Mar 13 16:07:47 2024 +0100 Bug 29948: Display authors information along with the identifiers Sponsored-by: Orex Digital Signed-off-by: Signed-off-by: Hugo Agud Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 11cdeb0889ecd4b2827690a6e7df45c912f2a9e1 Author: Matt Blenkinsop Date: Fri May 10 13:13:20 2024 +0000 Bug 36827: Fix tab formatting This patch removes unwanted whitespace between the tabs and the tab content Test plan: 1) Enable the ERM module and navigate to the eUsage > Reports sections 2) Observe the whitespace between the tabs and the content 3) Apply patch and run yarn build 4) Hard refresh the page, the whitespace should be gone Signed-off-by: Paul Derscheid Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit f3af09c78cbec3e091164e71f74c97bcb90f9978 Author: Matt Blenkinsop Date: Fri May 10 13:18:45 2024 +0000 Bug 36828: Remove commented out code Test plan: 1) Look at the patch diff and observe that the commented out code has been removed Signed-off-by: Paul Derscheid Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit 274c0bee86be52c9c66c0df3fccdd45c0c271977 Author: Fridolin Somers Date: Wed Mar 20 16:04:14 2024 +0100 Bug 36370: Add ContentWarningField to UNIMARC XSLT Bug 31123 added new feature with preference ContentWarningField. Add this behavior to UNMARC XSLT files. This patch adds new template 'tag_content_warning' in UNIMARCslimUtils.xsl called in results and details pages. New field is placed after 3xx. Test plan (in both interfaces OPAC and staff): 1) Create a new field 599 in framework 2) Set system preference ContentWarningField to 599 3) Edit a record to add a 599 with text in $a$b and an URL in $u 4) Perform a search to find this record => Check you see content_warning: $a $b 5) Click on details page => Check you see content_warning: $a $b Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit 6635f7393695b7963eeb7a91e76d36a64b0e5968 Author: Martin Renvoize Date: Wed Mar 6 16:24:25 2024 +0000 Bug 36373: Show existing bookings in the datepicker This patch exposes existing bookings as info dots in the flatpickr Signed-off-by: Esther Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit 93a5ec9ca4a5d7273a0fd03fe376608b299e00ba Author: Alex Buckley Date: Sun Mar 17 11:23:51 2024 +1300 Bug 36325: Add --exclude-logs option to koha-run-backups Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit c8bc861ec7a8ed4ba2426d65ea6de93db722df77 Author: danyonsewell Date: Fri Mar 15 01:21:53 2024 +0000 Bug 36325: Add option to koha-run-backups/koha-dump, to exclude logs Written patch to add flag to both koha-dump and koha-run-backups. Test plan: 1. do a sudo koha-dump and sudo koha-run-backups and check the contents of the .tar.gz backup in /var/spool/koha/instance/ and verify logs are in there 2. apply this patch 3. this time do sudo koha-dump --exclude-logs and sudo koha-run-backups --exclude-logs and check the contents of the .tar.gz backup in /var/spool/koha/instance and verify nothing from /var/log/koha is in there. Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit e48df518e842ebe0c1a1d383297f375e3da521d7 Author: Martin Renvoize Date: Mon Feb 19 09:50:22 2024 +0000 Bug 35813: Migrate 'transient_result' to 'messages.inc' This patch DRY's out the code by migrating the transient_result div into the now widely included messages.inc include. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit 21cda2fa638e19c783ac82e599190af51c1043c8 Author: Owen Leonard Date: Tue Jan 16 12:18:48 2024 +0000 Bug 35813: (follow-up) Correct dialog class and clean up whitespace This patch changes the class of the success message from "success" (which is a Bootstrap class) to "message" which is the class we use elsewhere in Koha for this kind of informational message. The patch adds the same dialog markup to labeledMARCdetail.tt. The patch also trims trailing whitespace from place_booking_modal.js Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit cef4c56d6ec7197340f8f86184fd305ded5f4b2a Author: Martin Renvoize Date: Mon Jan 15 16:45:03 2024 +0000 Bug 35813: Add success feedback after placing/editing bookings This patch restores the lost behaviour that a successful add/edit of a booking via the 'Place booking' modal should notify the end user that the submission was sucessful. Test plan 1) Set an item as bookable to expose the 'Place booking' button 2) Place a new booking from the following pages and confirm that you now recieve feedback. * Catalog > Title > Details * Catalog > Title > MARC details * Catalog > Title > ISBD details * Catalog > Title > Item details * Catalog > Title > Bookings 3) Edit a booking on the 'Catalog > Title > Bookings' page and confirm you now recieve feedback. Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit c74169ba27c2e12473239b15358e428bc05da9f5 Author: Janusz Kaczmarek Date: Mon May 6 13:24:10 2024 +0000 Bug 36794: Illegitimate modification of biblionumber subfield content (999 $c) It happens that librarians, by mistake, open a biblio editor putting in the URL, by hand, the biblionumber prefixed with a blank (e.g. .../addbiblio.pl?biblionumber= 123 -- mind the space before 123). In such a case the editor opens with the right biblio record (i.e. 123) but, after saving the record, the content of the biblionumber MARC field (999 $c for a standard MARC 21 installation) results modified and contains additional initial blanks. Moreover, while using ES and making a search for the record (with title, author etc.) we get two records on the result list (instead of one). This is because in the addbiblio.pl script $biblionumber is taken (and continuously used) directly from CGI parameter, without any validation and/or correction. Test plan: ========== 0. Have a test installation with ES. 1. Open a biblio record in the editor with an added space before biblionumber value, e.g.: http://ktd:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber= 123 Save the record. 2. From the Normal view choose Save -> MARCXML. Open the saved file in your favourite editor. You should see, at the end, something like: 123 (mind the space before 123). This is not right. 3. Make a search with the title or author's name from the record (e.g. Henning Mankell for the record 123 from the default ktd data set). You should get two records instead of one (while using ES). 4. Apply the patch, restart_all. Repeat p. 1 and 2 with a different biblionumber. Notice the unchanged (i.e. without spaces) value of 999 $c subfield in the exported record and only one record as a result of a search. WNC amended patch - rebased, added conditional in case no bib, moved comments to their own lines Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 4b66fbc4ebc0fe706f9a9b9057a19ee0c1b13aa3 Author: Janusz Kaczmarek Date: Tue May 7 09:13:54 2024 +0000 Bug 36799: Illegitimate modification of MARC authid field content (001) It happens that librarians to save time open an authority editor by putting in the URL, by hand, the authid prefixed, by mistake, with a blank (e.g. .../authorities.pl?authid= 100 -- mind the space before 100). In such a case the editor opens with the right auth record (i.e. 100) but, after saving the record, the content of the authid MARC field (001 for a standard MARC 21 installation) results modified and contains additional initial blanks. Moreover, if the heading (1XX field) was modified in the authority record during such an edit, the changes will not propagate to the linked bibliographic records. And won't in the future. This is because in the authorities.pl script $authid is taken (and continuously used) directly from CGI parameter, without any validation and/or correction (line 540 in the current main branch). Test plan: ========== 1. Open an auth record in the editor with an added space before authid value, e.g.: http://ktd:8081/cgi-bin/koha/authorities/detail.pl?authid= 100 Modify the heading field -- in the ktd data set: 150 Computerized typesetting Save the record. 2. a) Open the record for editing again--see the space added before the authid in field 001. Close the editor (with Cancel). b) Try to go to the linked biblio records with Used in X records. Note no results, if using ES. c) Remove the space before authid (after an:) in the URL. Go to the linked biblio records. See that the content of the field controlled by the modified auth record did not update. 3. Apply the patch; restart_all. 4. Repeat p. 1 and 2 with a different authid. Everything should be OK now. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit d2f41df188c3d8e8d8705c6a5ceb583e3e29e629 Author: Emmi Takkinen Date: Thu Apr 4 09:04:47 2024 +0300 Bug 33849: Do not reset new patrons home library when error occurs While adding new patron, if patron is flagged as duplicate or another error occurs and their home library differs from library user is logged in, patrons home library resets as logged in users library. This happens with all patrons expect those with category type C. This patch removes checking if patrons category type is C from code so that all category types use previously chosen home library even if error occurs. To test: 1. Add new patron and set their library to a different library than the one you're logged in. 2. Cause an error (wrong age, duplicate etc) while saving. 3. Attempt to save. => Note that patrons home library is set as one you're logged in. 4. Apply this patch. 5. Repeat steps 1 to 3. => Note that patrons home library hasn't changed. Sponsored-by: Koha-Suomi Oy Signed-off-by: Esther Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 2b3ad46f979d0ba2e5c0ea2e128597e9c8bf153e Author: Katrin Fischer Date: Mon May 13 08:33:50 2024 +0000 Bug 35149: DBRev 23.12.00.056 Signed-off-by: Katrin Fischer commit 42d95f362a89c9c2236220f6b961b1748792087f Author: David Gustafsson Date: Wed Feb 21 20:03:42 2024 +0100 Bug 35149: Change CircAutoPrintQuickSlip syspref explanation Signed-off-by: Laura Escamilla Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer commit 3d030ded6bc3d60b6a6e0ca8c6c648b5bb167e0e Author: Stefan Berndtsson Date: Mon Sep 25 14:05:06 2023 +0200 Bug 35149: Add Option to ignore submit of checkout field when empty 1) Apply patch 2) Set CircAutoPrintQuickSlip to "do nothing" 3) Go to the checkouts form for a specific patron 4) Submit the form with empty value 5) Verify that no action is taken and you stay on the current page Signed-off-by: Laura Escamilla Signed-off-by: Katrin Fischer commit 5cc42c162c51aa3624f5e46e2ad6c70dd5ee6f01 Author: Lucas Gass Date: Tue May 7 16:03:54 2024 +0000 Bug 36797: Change WHILE loop into FOREACH To test: 1. Find a record that has 1000 non-waiting holds with different priorities. 2. Try loading the reserve page for that record ( /reserve/request.pl?biblionumber=X ) 3. Error: Template process failed: undef error - WHILE loop terminated (> 1000 iterations) 4. APPLY PATCH 5. Try again, this time the page should load. 6. Try testing on a record with less than 1000 holds, making sure the priorities are still set right. 7. Make sure you can change your priorities and everything works right. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 1aba01adb4ff61c6af77af6b42f13d29d55df4f2 Author: Emily Lamancusa Date: Fri May 10 14:01:59 2024 -0400 Bug 36832: (bug 36791 follow-up) Allow authid=0 To test: 1. Go to the Authorities module and do a Z39.50 search that will return results (e.g. a general subject heading) 2. Import an authority record from the results --> Confirm that the record is imported into the editor 3. Authorities > New, replace it via Z39.50, confirm it's imported 4. Authorities > New, fill the required fields, confirm it saves 5. Edit an existing authority, replace it via Z39.50, confirm it saves 6. Edit an existing authority, replace authid=nn in the URL with a number that doesn't exist like 1000000, confirm you get a 404 page Signed-off-by: Phil Ringnalda Signed-off-by: Janusz Kaczmarek Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer commit b7a5cc5beeb4af7cd23a414519c038f007f5b959 Author: Fridolin Somers Date: Mon Jan 29 10:08:00 2024 +0100 Bug 35927: Selecting MARC framework again doesn't work when adding to basket from an external source Like Bug 19372, selecting MARC framework currently doesn't work when adding to basket from an external source. Strangly I can reproduce on koha-testing-docker, but we have this issue with a Ubuntu Focal install. Looks like it comes from a bad syntaxe than needs to be replaced in any case. Test plan: 1) Add an order to a basket from an external source 2) Select another framework than the default one on the search result view. Before doing 'add order' on choosen search result line. 3) Chek the framework code you will pick will be used in the created biblio record Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 5406aaedfa86aa97ed06019f4862bff285a4aad2 Author: Fridolin Somers Date: Fri Mar 15 16:02:11 2024 +0100 Bug 36335: Fix ILS-DI GetRecords bad encoding for UNIMARC ILS-DI GetRecords generates bad encoding of MARCXML for UNIMARC, like OAI in Bug 34467 Enable ILS-DI and display a record with : /cgi-bin/koha/ilsdi.pl?service=GetRecords&id= Well-known issue, fixed Signed-off-by: Frédéric Demians Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit af6a0b78b7d0e73176923d67501ef54511f6d435 Author: Matt Blenkinsop Date: Fri May 10 14:14:54 2024 +0000 Bug 34788: (follow-up): Fix translations Signed-off-by: Katrin Fischer